Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports aprox13 to C++ using the same strategy as for iso7 in #303
Here are the fcompare results between C++ and Fortran for the
test_rhs
unit test:fc_aprox13_rhs.txt
Here are the fcompare results between C++ and Fortran for the
test_react
unit test:fc_aprox13_react.txt
This PR also adds input files for
test_rhs
for aprox13 based on test_react inputs, except I've addedcall_eos_in_rhs=T
.To avoid completely refactoring the rhs in aprox13, I also enabled passing arbitrary size
Array1D
arrays to all esum functions by making esums templated functions.I've also run the
test_rhs
andtest_react
unit tests in debug mode and successfully got the exact same results as without debug mode.