Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aprox13 to C++ #305

Merged
merged 7 commits into from
Apr 17, 2020
Merged

Move aprox13 to C++ #305

merged 7 commits into from
Apr 17, 2020

Conversation

dwillcox
Copy link
Member

@dwillcox dwillcox commented Apr 16, 2020

This PR ports aprox13 to C++ using the same strategy as for iso7 in #303

Here are the fcompare results between C++ and Fortran for the test_rhs unit test:

fc_aprox13_rhs.txt

Here are the fcompare results between C++ and Fortran for the test_react unit test:

fc_aprox13_react.txt

This PR also adds input files for test_rhs for aprox13 based on test_react inputs, except I've added call_eos_in_rhs=T.

To avoid completely refactoring the rhs in aprox13, I also enabled passing arbitrary size Array1D arrays to all esum functions by making esums templated functions.

I've also run the test_rhs and test_react unit tests in debug mode and successfully got the exact same results as without debug mode.

@dwillcox dwillcox requested review from maxpkatz and zingale April 16, 2020 01:31
@maxpkatz maxpkatz merged commit f9823e0 into development Apr 17, 2020
@zingale zingale deleted the aprox13-cpp branch December 27, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants